GH-113486: Do not emit spurious PY_UNWIND events for optimized calls to classes.#113680
Merged
Conversation
gvanrossum
approved these changes
Jan 3, 2024
Member
|
Thanks for the quick action. I took the liberty of testing this branch. The events reported to the settrace function is changed: import linecache, sys
def trace(frame, event, arg):
# The weird globals here is to avoid a NameError on shutdown...
if frame.f_code.co_filename == globals().get("__file__"):
lineno = frame.f_lineno
line = linecache.getline(__file__, lineno).rstrip()
print("{} {}: {}".format(event[:4], lineno, line))
return trace
print(sys.version)
sys.settrace(trace)
def gen():
print(2)
yield 3
print(4)
print(next(gen()))Running with 3.12: Running with this branch: Do you mean to skip the return and call events from the yield? |
Member
|
BTW, the 3.13 behavior also happens with 3.13.0a2, so it's not due to the change in this branch, but seems related? |
Member
Author
Member
|
Sorry I was traveling and did not have a reliable network access. But the change looks good to me. |
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…calls to classes. (pythonGH-113680)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…calls to classes. (pythonGH-113680)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…calls to classes. (pythonGH-113680)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
CO_NO_MONITORING_EVENTSflag for use by shim frame code objects and similar, to avoid monitoring events.